Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSA import bugs on RemedialActionGroups, RAxAE instants coherence and onConstraint usage rules #970

Merged
merged 3 commits into from
Apr 12, 2024

Conversation

bqth29
Copy link
Collaborator

@bqth29 bqth29 commented Apr 12, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What is the new behavior (if this is a feature change)?
Import bugs for empty RemedialActionGroups and incoherent onConstraint usage rules were fixed.
Also, a fix was added such that ARAs can only have an onConstraint usage rule if they are linked to auto CNECs.

bqth29 added 3 commits April 12, 2024 17:01
Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>
Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>
Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>
@bqth29 bqth29 added the bug Something isn't working label Apr 12, 2024
@bqth29 bqth29 requested a review from jipea April 12, 2024 15:07
@jipea jipea merged commit 44833ba into main Apr 12, 2024
9 checks passed
MartinBelthle pushed a commit that referenced this pull request Apr 25, 2024
… onConstraint usage rules (#970)

* Fix import bug on groups

Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>

* Fix import bug on onConstraint

Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>

* Fix import bug on AExRA instants coherence

Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>

---------

Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>
Signed-off-by: belthlemar <martin.belthle@rte-france.com>
MartinBelthle pushed a commit that referenced this pull request May 28, 2024
… onConstraint usage rules (#970)

* Fix import bug on groups

Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>

* Fix import bug on onConstraint

Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>

* Fix import bug on AExRA instants coherence

Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>

---------

Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>
Signed-off-by: belthlemar <martin.belthle@rte-france.com>
@pet-mit pet-mit deleted the fix/csa_import_bugs branch June 20, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants