Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove computation log files #16

Merged
merged 2 commits into from
Aug 10, 2023
Merged

Remove computation log files #16

merged 2 commits into from
Aug 10, 2023

Conversation

olperr1
Copy link
Member

@olperr1 olperr1 commented Aug 10, 2023

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce?

Quality

What is the current behavior?

Some computation logs were previously added to test/resources repositories. They contain license messages which can be a problem for downstream users.

What is the new behavior (if this is a feature change)?
The computation logs are removed and the .gitignore file is modified to ignore this kind of files.

Signed-off-by: Olivier Perrin <olivier.perrin@rte-france.com>
Signed-off-by: Olivier Perrin <olivier.perrin@rte-france.com>
@olperr1 olperr1 requested a review from nicolas-pierr August 10, 2023 13:45
@sonarcloud
Copy link

sonarcloud bot commented Aug 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@olperr1 olperr1 merged commit bb46910 into main Aug 10, 2023
@olperr1 olperr1 deleted the remove_computation_log_files branch October 23, 2023 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants