Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add log level for ampl/knitro printing #30

Merged
merged 6 commits into from
Oct 27, 2023
Merged

Add log level for ampl/knitro printing #30

merged 6 commits into from
Oct 27, 2023

Conversation

p-arvy
Copy link
Member

@p-arvy p-arvy commented Oct 18, 2023

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

What kind of change does this PR introduce?

Add level of log in AMPL printing.

What is the current behavior?

Everything is printed.

What is the new behavior (if this is a feature change)?
The user can chose the level of AMPL printings.

Does this PR introduce a breaking change or deprecate an API?

  • The Breaking Change or Deprecated label has been added
  • The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

Other information:

Signed-off-by: parvy <pierre.arvy@artelys.com>
Signed-off-by: parvy <pierre.arvy@artelys.com>
@p-arvy p-arvy requested review from klorel and annetill October 18, 2023 14:44
@p-arvy p-arvy self-assigned this Oct 18, 2023
# Conflicts:
#	open-reac/src/main/resources/openreac/reactiveopf.run
Signed-off-by: parvy <pierre.arvy@artelys.com>
@p-arvy p-arvy changed the title [WIP] Add log level for ampl printing Add log level for ampl/knitro printing Oct 26, 2023
Signed-off-by: parvy <pierre.arvy@artelys.com>
@sonarcloud
Copy link

sonarcloud bot commented Oct 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@klorel klorel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job !

@klorel klorel merged commit 24606c7 into main Oct 27, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants