Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add configurable scaling before ACOPF solving #62

Merged
merged 19 commits into from
Apr 16, 2024
Merged

Add configurable scaling before ACOPF solving #62

merged 19 commits into from
Apr 16, 2024

Conversation

p-arvy
Copy link
Member

@p-arvy p-arvy commented Apr 1, 2024 •
edited
Loading

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

What kind of change does this PR introduce?

A scaling is added before ACOPF solving.

What is the current behavior?

No scaling is specified. So default scaling of the non-linear solver is applied before ACOPF solving.

What is the new behavior (if this is a feature change)?
A scaling is applied, with configurable values.

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

p-arvy added 6 commits April 1, 2024 12:30
@p-arvy
Add scaling of variables/constraints before ACOPF solving.
5e851ff 
Signed-off-by: parvy <pierre.arvy@artelys.com>
@p-arvy
Add json serialization/deserialization of new parameters for scaling.
71a36e0 
Signed-off-by: parvy <pierre.arvy@artelys.com>
@p-arvy
Add TUs for Java developments.
216b102 
Signed-off-by: parvy <pierre.arvy@artelys.com>
@p-arvy
Add configurability of scaling factors in AMPL code.
0e806cb 
Signed-off-by: parvy <pierre.arvy@artelys.com>
@p-arvy
Add TUs with comparisons of the outputs of AMPL code.
d1f46a9 
Signed-off-by: parvy <pierre.arvy@artelys.com>
@p-arvy
remove local path in config.yml.
41d7c19 
Signed-off-by: parvy <pierre.arvy@artelys.com>
@p-arvy p-arvy requested review from klorel and So-Fras April 1, 2024 10:33
@p-arvy p-arvy self-assigned this Apr 1, 2024
p-arvy added 5 commits April 1, 2024 12:46
@p-arvy
Add documentation for scaling before ACOPF solving.
caa3f24 
Signed-off-by: parvy <pierre.arvy@artelys.com>
@p-arvy
Improve documentation.
ac18a15 
Signed-off-by: parvy <pierre.arvy@artelys.com>
@p-arvy
Fix TUs.
07caca5 
Signed-off-by: parvy <pierre.arvy@artelys.com>
@p-arvy
Fix documentation.
3962919 
Signed-off-by: parvy <pierre.arvy@artelys.com>
@p-arvy
Fix documentation.
b617343 
Signed-off-by: parvy <pierre.arvy@artelys.com>
p-arvy added 4 commits April 3, 2024 18:22
@p-arvy
remove acopf_scaling.run file.
ff71212 
Signed-off-by: parvy <pierre.arvy@artelys.com>
@p-arvy
update README.
2ee7ab1 
Signed-off-by: parvy <pierre.arvy@artelys.com>
@p-arvy
update OR model in Java.
39f7ec9 
Signed-off-by: parvy <pierre.arvy@artelys.com>
@p-arvy
update authors.
8649f98 
Signed-off-by: parvy <pierre.arvy@artelys.com>
So-Fras
So-Fras requested changes Apr 5, 2024
View reviewed changes
Copy link
Member

@So-Fras So-Fras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the review comments are typos.
The main question for me is about the test resource files that seem to vary with the optimization run. Can we avoid it?

open-reac/src/main/java/com/powsybl/openreac/parameters/input/OpenReacParameters.java Outdated Show resolved Hide resolved
open-reac/src/main/java/com/powsybl/openreac/parameters/input/OpenReacParameters.java Outdated Show resolved Hide resolved
open-reac/src/main/java/com/powsybl/openreac/parameters/input/OpenReacParameters.java Outdated Show resolved Hide resolved
open-reac/src/main/java/com/powsybl/openreac/parameters/input/OpenReacParameters.java Outdated Show resolved Hide resolved
open-reac/src/main/java/com/powsybl/openreac/parameters/input/OpenReacParameters.java Outdated Show resolved Hide resolved
...c/src/main/java/com/powsybl/openreac/parameters/input/json/OpenReacParametersSerializer.java Outdated Show resolved Hide resolved
...c/src/main/java/com/powsybl/openreac/parameters/input/json/OpenReacParametersSerializer.java Outdated Show resolved Hide resolved
open-reac/src/main/resources/openreac/reactiveopf.run Outdated Show resolved Hide resolved
open-reac/src/test/resources/mock_outputs/reactiveopf_results_indic.txt Show resolved Hide resolved
...src/main/java/com/powsybl/openreac/parameters/input/json/OpenReacParametersDeserializer.java Outdated Show resolved Hide resolved
p-arvy added 4 commits April 5, 2024 12:36
@p-arvy
refactor variable names in Java.
2a698d5 
Signed-off-by: parvy <pierre.arvy@artelys.com>
@p-arvy
refactor variable names in AMPL/README.
c0b9f12 
Signed-off-by: parvy <pierre.arvy@artelys.com>
@p-arvy
refactor OpenReacParametersDeserializer class.
f514a0c 
Signed-off-by: parvy <pierre.arvy@artelys.com>
@p-arvy
refactor.
701b1d3 
Signed-off-by: parvy <pierre.arvy@artelys.com>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
98.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

So-Fras
So-Fras approved these changes Apr 9, 2024
View reviewed changes
Copy link
Member

@So-Fras So-Fras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work! Regarding the test resources that are dependent on date, elapsed time, local directory, I agree that this could be dealt with in another PR.

@So-Fras So-Fras merged commit 6acab12 into main Apr 16, 2024
6 checks passed
@So-Fras So-Fras deleted the scaling_before_ACOPF_solving branch April 16, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@So-Fras So-Fras So-Fras approved these changes

@klorel klorel klorel approved these changes

Assignees

@p-arvy p-arvy

Labels
Java/AMPL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@p-arvy @klorel @So-Fras