Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests to test the breaking changes in README.md examples #6

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

flo-dup
Copy link
Contributor

@flo-dup flo-dup commented Sep 21, 2022

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem ?
No

What kind of change does this PR introduce?
Feature

What is the current behavior?
Code in the 7 README.md examples might become deprecated or incorrect following a release.

What is the new behavior (if this is a feature change)?
Breaking changes in the 7 README.md examples are detected by unit tests but in a separate module, in order not to pollute the powsybl-starter pom.xml with junit dependency.

Does this PR introduce a breaking change or deprecate an API?
No

Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant