feat: avoid computation failure if an error occurs in post run treatment #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheMaskedTurtle
force-pushed
the
feat/log-error-in-post-run
branch
3 times, most recently
from
dbd0bcd to
3433fd0
Compare
Signed-off-by: Joris Mancini <joris.mancini_externe@rte-france.com>
TheMaskedTurtle
force-pushed
the
feat/log-error-in-post-run
branch
from
3433fd0 to
0ecb865
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
It avoids a computation to fail if a postRun treatment fails, as it means that the real computation went well already.
What is the current behavior?
Currently the whole computation fails if we don't succeed to save reports for example.
Does this PR introduce a breaking change or deprecate an API?