Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds tie and hvdc lines to the map-viewer widget #19

Merged
merged 3 commits into from
Sep 4, 2024
Merged

Conversation

CBiasuzzi
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

What kind of change does this PR introduce?

feature

What is the current behavior?

What is the new behavior (if this is a feature change)?
displays network's tie lines and HVDC lines in the mapviewer widget

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

Signed-off-by: Christian Biasuzzi <christian.biasuzzi@soft.it>
Signed-off-by: Christian Biasuzzi <christian.biasuzzi@soft.it>
examples/demo_mapviewer_features.ipynb Outdated Show resolved Hide resolved
examples/demo_mapviewer_features.ipynb Outdated Show resolved Hide resolved
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Copy link
Contributor

@flo-dup flo-dup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently in powybl-iidm-impl

  • there cannot be a linePosition extension on HVDC lines
  • there cannot be a linePosition extension on tielines, the positions are expected on the dangling lines

Hence,

  • there cannot be with current powsybl-iidm-impl state the detailed line for HVDC lines (always straight lines between corresponding substations) as the data is not in iidm extensions
  • for tielines we could display the detailed line though, but we need to look for extensions on the dangling lines, I'll write an issue about that
  • and for unpaired dangling lines we could also display it, but that's a separated feature (the widget does not handle a line with no substation on one side, and not sure the viewer handles it either)

@flo-dup flo-dup merged commit 2ed89c4 into main Sep 4, 2024
4 checks passed
@flo-dup flo-dup deleted the tie_hvdc_lines branch September 4, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants