Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAD lazy processing for the explorer #28

Merged
merged 6 commits into from
Nov 6, 2024
Merged

Conversation

CBiasuzzi
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

Fixes #18 : if NAD tab is not displayed the NAD is not computed.

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

Base automatically changed from updates_diagram_viewer to main October 10, 2024 20:17
…layed tab and displays an "in progress" status message during the computation

Signed-off-by: Christian Biasuzzi <christian.biasuzzi@soft.it>
@flo-dup flo-dup force-pushed the explorer_nad_lazy_processing branch from 4a9f860 to c7f705e Compare October 10, 2024 20:19
src/pypowsybl_jupyter/networkexplorer.py Outdated Show resolved Hide resolved
src/pypowsybl_jupyter/networkexplorer.py Outdated Show resolved Hide resolved
src/pypowsybl_jupyter/networkexplorer.py Outdated Show resolved Hide resolved
CBiasuzzi and others added 4 commits October 17, 2024 22:14
… includes other fixes from feedbacks

Signed-off-by: Christian Biasuzzi <christian.biasuzzi@soft.it>
…ble sending of events, from the js to python; removes useless js code;

Signed-off-by: Christian Biasuzzi <christian.biasuzzi@soft.it>
Signed-off-by: Christian Biasuzzi <christian.biasuzzi@soft.it>
…cessing

Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup flo-dup linked an issue Oct 28, 2024 that may be closed by this pull request
src/pypowsybl_jupyter/nadwidget.py Show resolved Hide resolved
src/pypowsybl_jupyter/networkexplorer.py Show resolved Hide resolved
src/pypowsybl_jupyter/networkexplorer.py Show resolved Hide resolved
src/pypowsybl_jupyter/networkexplorer.py Show resolved Hide resolved
… (SLD)

Signed-off-by: Christian Biasuzzi <christian.biasuzzi@soft.it>
@flo-dup flo-dup merged commit 9017d53 into main Nov 6, 2024
4 checks passed
@flo-dup flo-dup deleted the explorer_nad_lazy_processing branch November 6, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Responsive widget, even with a high NAD depth
2 participants