Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix API refactoring for python 3.7 #649

Merged
merged 5 commits into from
Sep 19, 2023
Merged

Fix API refactoring for python 3.7 #649

merged 5 commits into from
Sep 19, 2023

Conversation

EtienneLt
Copy link
Contributor

@EtienneLt EtienneLt commented Sep 19, 2023

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

No

What kind of change does this PR introduce?

Bug fix

What is the current behavior?

CI is broken for Python 3.7 since #641 has been merged

What is the new behavior (if this is a feature change)?
CI is repaired

Does this PR introduce a breaking change or deprecate an API?

  • The Breaking Change or Deprecated label has been added
  • The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

Other information:

Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>
@EtienneLt EtienneLt self-assigned this Sep 19, 2023
Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>
geofjamg and others added 3 commits September 19, 2023 17:13
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>
@geofjamg geofjamg changed the title fix refactoring Fix API refactoring for python 3.7 Sep 19, 2023
@geofjamg geofjamg merged commit 41c5074 into main Sep 19, 2023
7 checks passed
@geofjamg geofjamg deleted the fix-refactoring branch September 19, 2023 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants