Adding dangling line's generation part mapping #821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update when no generation created to do Signed-off-by: Hugo KULESZA <hugo.kulesza@rte-france.com>
Signed-off-by: Hugo KULESZA <hugo.kulesza@rte-france.com>
Signed-off-by: Hugo KULESZA <hugo.kulesza@rte-france.com>
HugoKulesza
changed the title
Signed-off-by: Hugo KULESZA <hugo.kulesza@rte-france.com>
This reverts commit a6a2dd0. Signed-off-by: Hugo KULESZA <hugo.kulesza@rte-france.com>
Signed-off-by: Hugo KULESZA <hugo.kulesza@rte-france.com>
Signed-off-by: Hugo KULESZA <hugo.kulesza@rte-france.com>
Signed-off-by: Hugo KULESZA <hugo.kulesza@rte-france.com>
Signed-off-by: Hugo KULESZA <hugo.kulesza@rte-france.com>
HugoKulesza
changed the title
Signed-off-by: Hugo KULESZA <hugo.kulesza@rte-france.com>
…/pypowsybl into dangling-line-generation Signed-off-by: Hugo KULESZA <hugo.kulesza@rte-france.com>
geofjamg
reviewed
Nov 20, 2024
| @@ -28,6 +28,7 @@ | |||
|
|
|||
| import static com.powsybl.dataframe.MappingUtils.*; | |||
| import static com.powsybl.dataframe.network.PerUnitUtil.*; | |||
| import static java.lang.Double.NaN; | |||
There was a problem hiding this comment.
Could we avoid this useless change ?
pypowsybl/network/impl/network.py
Outdated
| @@ -1244,14 +1244,20 @@ def get_dangling_lines(self, all_attributes: bool = False, attributes: List[str] | |||
| - **ucte-xnode-code**: deprecated for pairing key. | |||
| - **paired**: if the dangling line is paired with a tie line | |||
| - **tie_line_id**: the ID of the tie line if the dangling line is paired | |||
| - **min_p** (optional): Minimum active power output of the dangling line's generation part | |||
| @@ -1293,6 +1299,35 @@ def get_dangling_lines(self, all_attributes: bool = False, attributes: List[str] | |||
| """ | |||
| return self.get_elements(ElementType.DANGLING_LINE, all_attributes, attributes, **kwargs) | |||
|
|
|||
| def get_dangling_lines_generation(self, all_attributes: bool = False, attributes: List[str] = None, | |||
There was a problem hiding this comment.
what is the purpose of **kwargs ?
| @@ -3939,17 +4007,18 @@ def create_batteries(self, df: DataFrame = None, **kwargs: ArrayLike) -> None: | |||
| """ | |||
| return self._create_elements(ElementType.BATTERY, [df], **kwargs) | |||
|
|
|||
| def create_dangling_lines(self, df: DataFrame = None, **kwargs: ArrayLike) -> None: | |||
| def create_dangling_lines(self, df: DataFrame = None, generation_df: DataFrame = pd.DataFrame(), **kwargs: ArrayLike) -> None: | |||
There was a problem hiding this comment.
Is **kwargs stil working for example to pass the dangling base attributes inline and the generation part with generation_df ?
n.create_dangling_line(id='X', r=3.4, ..., generation_df=...)There was a problem hiding this comment.
Yes, the tests use create_dangling_lines this way to verify it still works.
On the other end, data for generation_df cannot be passed using kwargs
Signed-off-by: Hugo KULESZA <hugo.kulesza@rte-france.com>
geofjamg
approved these changes
Nov 20, 2024
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update when no generation created to do
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
Fixing #793
Does this PR introduce a breaking change or deprecate an API?