-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix non-linear shunt compensator section number #900
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Damien Jeandemange <damien.jeandemange@artelys.com>
jeandemanged
changed the title
[WIP] Fix non-linear shunt compensator section number
Fix non-linear shunt compensator section number
Nov 20, 2024
jeandemanged
commented
Nov 20, 2024
java/src/main/java/com/powsybl/dataframe/network/NetworkDataframes.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Damien Jeandemange <damien.jeandemange@artelys.com>
geofjamg
reviewed
Nov 22, 2024
java/src/main/java/com/powsybl/dataframe/network/NetworkDataframes.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com> Signed-off-by: jeandemanged <damien.jeandemange@artelys.com>
geofjamg
approved these changes
Dec 10, 2024
Quality Gate passed for 'pypowsybl'Issues Measures |
Quality Gate passed for 'pypowsybl'Issues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Bugfix
What is the current behavior?
For non-linear shunt compensators, the first section in
get_non_linear_shunt_compensator_sections
andupdate_non_linear_shunt_compensator_sections
is assumed to be 0 in the dataframe.This offset is confusing, e.g. for Entsoe's MicroGrid T4 (CGMES_v2.4.15_MicroGridTestConfiguration_T4_Assembled_BB_Complete_v2.zip), we get a
max_section_count
of 5 and the list of sections is 0...4. Updating section 5 values results in an error.Note that in
update_shunt_compensators
settingsection_count
works OK: 0 means disconnected.What is the new behavior (if this is a feature change)?
As per powsybl-core documentation, first section should be 1 // 0 meaning shunt disconnected.
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Other information: