Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add attributes to node/breaker graph #911

Merged
merged 6 commits into from
Dec 11, 2024
Merged

Conversation

geofjamg
Copy link
Member

@geofjamg geofjamg commented Dec 9, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

No

What kind of change does this PR introduce?

Feature

What is the current behavior?

When creating a networkx graph from a node/breaker topo, we only create the structure, all other nodes and switches infos are missed.

What is the new behavior (if this is a feature change)?
We attached attributes to nodes and edges of the networkx graph with nodes and switches dataframes infos.

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>
@geofjamg geofjamg requested a review from HugoKulesza December 9, 2024 16:37
@geofjamg geofjamg changed the base branch from main to node_breaker_topo_element_type December 10, 2024 08:09
Base automatically changed from node_breaker_topo_element_type to main December 10, 2024 09:13
Copy link

sonarcloud bot commented Dec 11, 2024

Copy link

sonarcloud bot commented Dec 11, 2024

@geofjamg geofjamg merged commit 2ac515b into main Dec 11, 2024
9 checks passed
@geofjamg geofjamg deleted the node_breaker_graph_attributes branch December 11, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants