Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate ppb.BaseSprite in favor of ppb.Sprite #355

Closed
pathunstrom opened this issue Aug 24, 2019 · 0 comments · Fixed by #357
Closed

Deprecate ppb.BaseSprite in favor of ppb.Sprite #355

pathunstrom opened this issue Aug 24, 2019 · 0 comments · Fixed by #357
Labels
new contributor Apply to issues we think can be tackled by people new to PPB
Milestone
Breakup ppb.sprit...

Comments

@pathunstrom
Copy link
Collaborator

Like many breaking changes in ppb before 1.0, we want to give a minimum of 1 release of deprecation warning. To do so, we're going to need to make a BaseSprite stub in ppb.__init__ that warns of deprecation, with instructions on how to use the new BaseSprite (by importing the sprites module) or to use the new ppb.Sprite

Subissue of #347

Depends on #354
@pathunstrom pathunstrom mentioned this issue Aug 24, 2019
Closed
4 tasks
@pathunstrom pathunstrom added the new contributor Apply to issues we think can be tackled by people new to PPB label Aug 24, 2019
@pathunstrom pathunstrom mentioned this issue Aug 24, 2019
Merged
@bors bors bot closed this as completed in 6923191 Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
new contributor Apply to issues we think can be tackled by people new to PPB
Projects
None yet
Milestone
Breakup ppb.sprites.BaseSprite
Development

Successfully merging a pull request may close this issue.

Refactors sprites.BaseSprite pathunstrom/pursuedpybear
1 participant
@pathunstrom