Refactors sprites.BaseSprite #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pathunstrom
changed the title
AstraLuma
requested changes
Aug 24, 2019
| @@ -15,6 +15,8 @@ | |||
| DEFAULT_RESOLUTION = 800, 600 | |||
|
|
|||
|
|
|||
| # TODO: Move Image out of the renderer so sprites can type hint | |||
| # appropriately. | |||
There was a problem hiding this comment.
I've been type-hinting with Asset to avoid this, but yeah, we have a circular dependency problem.
bors bot
added a commit
that referenced
this pull request
Aug 28, 2019
357: Refactors sprites.BaseSprite r=astronouth7303 a=pathunstrom I was just going to handle the rename, but decided to do all of this together with an okay from @astronouth7303. Not ready for merge, going to clean up the docs around Sprites and add tests for ppb.sprites.Sprite and ppb.BaseSprite. Additionally, would like to cleave out the various bits from the mixins into their own tests. Resolves #347 Resolves #352 Resolves #353 Resolves #354 Resolves #355 Co-authored-by: Piper Thunstrom <pathunstrom@gmail.com>
Build succeeded
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was just going to handle the rename, but decided to do all of this together with an okay from @astronouth7303. Not ready for merge, going to clean up the docs around Sprites and add tests for ppb.sprites.Sprite and ppb.BaseSprite. Additionally, would like to cleave out the various bits from the mixins into their own tests.
Resolves #347
Resolves #352
Resolves #353
Resolves #354
Resolves #355