Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Immutable vectors #204

Merged
merged 3 commits into from
May 5, 2019
Merged

Immutable vectors #204

merged 3 commits into from
May 5, 2019

Conversation

AstraLuma
Copy link
Member

@AstraLuma AstraLuma commented Jan 13, 2019 •
edited
Loading

Refactor the sides APIs to not mutate Vectors anymore.

Closes #188

(Note: This is WIP because it depends on Vector 1.0 APIs. It is otherwise ready for review.)

@AstraLuma AstraLuma mentioned this pull request Jan 18, 2019
Merged
nbraud
nbraud reviewed Jan 24, 2019
View reviewed changes
ppb/sprites.py Outdated Show resolved Hide resolved
@AstraLuma AstraLuma requested a review from a team as a code owner April 4, 2019 21:40
nbraud
nbraud requested changes Apr 8, 2019
View reviewed changes
ppb/sprites.py Outdated Show resolved Hide resolved
ppb/sprites.py Outdated Show resolved Hide resolved
ppb/sprites.py Show resolved Hide resolved
ppb/sprites.py Outdated Show resolved Hide resolved
@nbraud
Copy link
Contributor

nbraud commented Apr 8, 2019

@astronouth7303 Would it be possible to make it work with both versions of ppb-vector?

Currently the vector 1.0 release should block on this (because pursuedpybear doesn't specify a version constraint, so users and CI might upgrade at any point after the release), but this can't be merged before we cut a new version.

@nbraud
Copy link
Contributor

nbraud commented Apr 8, 2019

PS: Once #232 lands, this branch should update the version dependency on ppb-vector (probably to ~= 1.0)

nbraud
nbraud reviewed Apr 8, 2019
View reviewed changes
ppb/sprites.py Outdated Show resolved Hide resolved
nbraud
nbraud reviewed Apr 8, 2019
View reviewed changes
ppb/sprites.py Outdated Show resolved Hide resolved
@nbraud nbraud mentioned this pull request Apr 12, 2019
Closed
pathunstrom
pathunstrom approved these changes Apr 13, 2019
View reviewed changes
Copy link
Collaborator

@pathunstrom pathunstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, I think this is good to go once ppb-vector1.0.0a1 is available.

@AstraLuma AstraLuma changed the title [WIP] Immutable vectors Immutable vectors Apr 13, 2019
nbraud
nbraud previously requested changes Apr 14, 2019
View reviewed changes
ppb/sprites.py Outdated Show resolved Hide resolved
ppb/sprites.py Outdated Show resolved Hide resolved
requirements.txt Outdated Show resolved Hide resolved
nbraud
nbraud reviewed Apr 14, 2019
View reviewed changes
ppb/sprites.py Outdated Show resolved Hide resolved
@nbraud nbraud mentioned this pull request Apr 17, 2019
Closed
@AstraLuma AstraLuma mentioned this pull request Apr 23, 2019
Merged
@AstraLuma
Copy link
Member Author

I would like to get this merged in. Maybe we can rollback the docker stuff until Cirrus improves their container caching?

@pathunstrom
Copy link
Collaborator

pathunstrom commented Apr 23, 2019 •
edited
Loading

I'm okay with that. @nbraud That was your work, what're your thoughts?

@nbraud nbraud mentioned this pull request Apr 25, 2019
Open
@AstraLuma
Copy link
Member Author

bors r+

@bors
Copy link
Contributor

bors bot commented May 5, 2019

Merge conflict

@AstraLuma
Copy link
Member Author

bors r+

@AstraLuma AstraLuma closed this May 5, 2019
@bors
Copy link
Contributor

bors bot commented May 5, 2019

Already running a review

@AstraLuma AstraLuma reopened this May 5, 2019
@AstraLuma
Copy link
Member Author

bors retry

bors bot added a commit that referenced this pull request May 5, 2019
@bors @AstraLuma
Merge #204
6b4293b 
204: Immutable vectors r=astronouth7303 a=astronouth7303

Refactor the sides APIs to not mutate Vectors anymore.

Closes #188 

(Note: This is WIP because it depends on Vector 1.0 APIs. It is otherwise ready for review.)

Co-authored-by: Jamie Bliss <jamie@ivyleav.es>
@AstraLuma AstraLuma dismissed nbraud’s stale review May 5, 2019 16:28

All issues brought up have been resolved

@bors
Copy link
Contributor

bors bot commented May 5, 2019

Build succeeded

  • docs
  • Linux container:python:3.6-slim
  • Linux container:python:3.7-slim
  • macOS PYTHON:3.6.8
  • macOS PYTHON:3.7.2
  • Windows container:python:3.6-windowsservercore-1809
  • Windows container:python:3.7-windowsservercore-1809

@bors bors bot merged commit 8c28091 into ppb:master May 5, 2019
@AstraLuma AstraLuma deleted the immutable-vectors branch May 5, 2019 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbraud nbraud nbraud left review comments

@pathunstrom pathunstrom pathunstrom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make Vectors immutable
3 participants
@AstraLuma @nbraud @pathunstrom