Add rotatability to sprites. #214
Conversation
pathunstrom
changed the title
|
Assuming it passes Travis, this should be ready to go. |
|
|
||
| @rotation.setter | ||
| def rotation(self, value): | ||
| self._rotation = value % 360 |
There was a problem hiding this comment.
This can still be negative; should this use the same convention as ppb-vector and have -180 < _rotation <= 180?
There was a problem hiding this comment.
In the case of this interface, dunno if it matters. The tests have some negative rotation and it gives the equivalent positive rotation, which is a reasonable result, but if both you and @astronouth7303 feel like I should port that over here, I will.
There was a problem hiding this comment.
@pathunstrom I don't think it's much of an issue either way, I just wanted to check that was intentional.
| @@ -140,7 +140,34 @@ def _attribute_gate(self, attribute, bad_sides): | |||
| raise AttributeError(message) | |||
|
|
|||
|
|
|||
| class BaseSprite(EventMixin): | |||
| class Rotatable: | |||
There was a problem hiding this comment.
Rotatable sounds weird to me, but I'm a silly non-native speaker. shrugs
There was a problem hiding this comment.
Native speaker, sounds weird to me, too, but lots of mixins are named based on their capabilities.
There was a problem hiding this comment.
-able is approximately the right convention, but it leads to lots of weird words.
I would also accept CanBe*? Also weird.
There was a problem hiding this comment.
So like CanBeRotated?
There was a problem hiding this comment.
Or just CanRotate? In any case, I don't think Rotatable is a big issue, I was just very confused whether there was a typo, or it was just weird, or I was just bad at English.
Co-Authored-By: pathunstrom <pathunstrom@gmail.com>
First pass at this. Will still need to add the functionality to rotate the images themselves.
Closes #142