Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix registration #228

Merged
merged 8 commits into from
Apr 13, 2019
Merged

Fix registration #228

merged 8 commits into from
Apr 13, 2019

Conversation

pathunstrom
Copy link
Collaborator

Changes GameEngine.register from accepting values to accepting callbacks. This allows dynamic values to be applied as part of event publication extension.

@pathunstrom pathunstrom requested a review from a team as a code owner April 3, 2019 15:28
@pathunstrom pathunstrom changed the title Fix registration [WIP] Fix registration Apr 3, 2019
@pathunstrom pathunstrom added the tests Related to tests. When applied to PRs is a note that tests are required before merge. label Apr 3, 2019
nbraud
nbraud reviewed Apr 4, 2019
View reviewed changes
ppb/engine.py Outdated Show resolved Hide resolved
AstraLuma
AstraLuma reviewed Apr 4, 2019
View reviewed changes
ppb/engine.py Outdated Show resolved Hide resolved
@pathunstrom pathunstrom removed the tests Related to tests. When applied to PRs is a note that tests are required before merge. label Apr 13, 2019
@pathunstrom pathunstrom changed the title [WIP] Fix registration Fix registration Apr 13, 2019
@AstraLuma
Copy link
Member

You haven't implemented the type wildcard?

@pathunstrom
Copy link
Collaborator Author

Right. Will get on that.

AstraLuma
AstraLuma approved these changes Apr 13, 2019
View reviewed changes
Copy link
Member

@AstraLuma AstraLuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AstraLuma
Copy link
Member

bors r+

bors bot added a commit that referenced this pull request Apr 13, 2019
@bors @pathunstrom
Merge #228
a15aba1 
228: Fix registration r=astronouth7303 a=pathunstrom

Changes GameEngine.register from accepting values to accepting callbacks. This allows dynamic values to be applied as part of event publication extension.

Co-authored-by: Piper Thunstrom <pathunstrom@gmail.com>
@bors
Copy link
Contributor

bors bot commented Apr 13, 2019

Build succeeded

  • dockerfiles
  • docs
  • Linux Dockerfile:.ci/dockerfiles/python_3.6-slim
  • Linux Dockerfile:.ci/dockerfiles/python_3.7-slim
  • macOS PYTHON:3.6.8
  • macOS PYTHON:3.7.2
  • Windows Dockerfile:.ci/dockerfiles/python_3.6-windowsservercore-1809
  • Windows Dockerfile:.ci/dockerfiles/python_3.7-windowsservercore-1809

@bors bors bot merged commit baa070a into ppb:master Apr 13, 2019
@pathunstrom pathunstrom deleted the fix_registration branch October 24, 2020 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbraud nbraud nbraud left review comments

@AstraLuma AstraLuma AstraLuma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pathunstrom @AstraLuma @nbraud