Adds engine extension keyword argument #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AstraLuma
approved these changes
Jun 18, 2019
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jun 18, 2019
295: Adds engine extension keyword argument r=astronouth7303 a=pathunstrom Resolves #263. Went with `basic_systems` and `systems`. Used pycharm refactoring tools to change all references to the old `systems` and update to the new `basic_systems`, then modified a test to require our new `systems` keyword argument, then combined using `chain` that was already in the `engine.py` namespace. Co-authored-by: Piper Thunstrom <pathunstrom@gmail.com>
Timed out |
|
bors retry |
bors bot
added a commit
that referenced
this pull request
Jun 19, 2019
295: Adds engine extension keyword argument r=astronouth7303 a=pathunstrom Resolves #263. Went with `basic_systems` and `systems`. Used pycharm refactoring tools to change all references to the old `systems` and update to the new `basic_systems`, then modified a test to require our new `systems` keyword argument, then combined using `chain` that was already in the `engine.py` namespace. Co-authored-by: Piper Thunstrom <pathunstrom@gmail.com>
Build succeeded
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #263.
Went with
basic_systemsandsystems. Used pycharm refactoring tools to change all references to the oldsystemsand update to the newbasic_systems, then modified a test to require our newsystemskeyword argument, then combined usingchainthat was already in theengine.pynamespace.