Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull event name transformation into engine. #402

Merged
merged 1 commit into from
Mar 29, 2020
Merged

Pull event name transformation into engine. #402

merged 1 commit into from
Mar 29, 2020

Conversation

pathunstrom
Copy link
Collaborator

@pathunstrom pathunstrom commented Mar 28, 2020 •
edited by AstraLuma
Loading

Closes #390

@pathunstrom pathunstrom requested a review from a team as a code owner March 28, 2020 19:59
AstraLuma
AstraLuma approved these changes Mar 28, 2020
View reviewed changes
Copy link
Member

@AstraLuma AstraLuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm observing something like 10x~20x improvement with these changes.

We're still not to the point where i can run ppb_mutant.index at 30FPS, but this is a dramatic push in that direction.

ppb/engine.py
@@ -127,17 +141,26 @@ def publish(self):
scene = self.current_scene
event.scene = scene
extensions = chain(self.event_extensions[type(event)], self.event_extensions[...])

# Hydrating extensions.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Odd phrasing?

tests/test_events.py
assert fire_event is passed_fire


def test_event_mixin_with_bad_signature():
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a fan of losing this test, but I also can't think of a good way to handle it.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, I think I need to puzzle on how to get it. It's a lot heavier of a test now.

@AstraLuma
Copy link
Member

bors r+

@bors
Copy link
Contributor

bors bot commented Mar 29, 2020

Build succeeded

@bors bors bot merged commit 991680f into ppb:master Mar 29, 2020
@AstraLuma AstraLuma mentioned this pull request Mar 29, 2020
Closed
@pathunstrom pathunstrom deleted the event-optimization branch April 15, 2020 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AstraLuma AstraLuma AstraLuma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Event Optimization
2 participants
@pathunstrom @AstraLuma