Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assets 2: Chained assets #436

Merged
merged 11 commits into from
Apr 26, 2020
Merged

Assets 2: Chained assets #436

merged 11 commits into from
Apr 26, 2020

Conversation

AstraLuma
Copy link
Member

Depends on #432

Implements chained assets: Assets that depend on other assets (such as how Text depends on Fonts)

Closes #373

@AstraLuma AstraLuma marked this pull request as ready for review April 19, 2020 23:37
@AstraLuma AstraLuma requested a review from a team as a code owner April 19, 2020 23:37
@AstraLuma AstraLuma mentioned this pull request Apr 21, 2020
Merged
pathunstrom
pathunstrom reviewed Apr 23, 2020
View reviewed changes
Copy link
Collaborator

@pathunstrom pathunstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good, I just would like some comments in the tests to make it clear what's even being tested and what it's trying to prove.

tests/test_assets.py


def test_chained(clean_assets):
class Const(BackgroundMixin, AbstractAsset):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is kind of magical, can we get a comment that this is essentially a threaded string.join so folks at least get the intent?

tests/test_assets.py
with engine:
engine.start()

assert a.load(timeout=5)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what this is intended to test? Just that all of these workers are loaded in less than 5 seconds?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's so that if the chaining deadlocks, the test fails instead of pytest just sitting.

(Yes, this happened quite a bit in development.)

pathunstrom
pathunstrom approved these changes Apr 26, 2020
View reviewed changes
Copy link
Collaborator

@pathunstrom pathunstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@bors
Copy link
Contributor

bors bot commented Apr 26, 2020

Build succeeded:

@bors bors bot merged commit 710f571 into ppb:master Apr 26, 2020
bors bot added a commit that referenced this pull request Apr 26, 2020
@bors @AstraLuma
Merge #443
babf53d 
443: Text r=pathunstrom a=astronouth7303

Implements basic text rending. No wrapping or rich text supported.

Depends on #432, #436 

Closes #146 

Co-authored-by: Jamie Bliss <jamie@ivyleav.es>
bors bot added a commit that referenced this pull request Apr 26, 2020
@bors @AstraLuma
Merge #443
92a2a20 
443: Text r=pathunstrom a=astronouth7303

Implements basic text rending. No wrapping or rich text supported.

Depends on #432, #436 

Closes #146 

Co-authored-by: Jamie Bliss <jamie@ivyleav.es>
@AstraLuma AstraLuma deleted the chained-assets branch May 11, 2020 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pathunstrom pathunstrom pathunstrom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Chained Assets
2 participants
@AstraLuma @pathunstrom