Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds documentation of ppb.__init__. #451

Merged
merged 1 commit into from
Apr 26, 2020
Merged

Conversation

pathunstrom
Copy link
Collaborator

@pathunstrom pathunstrom commented Apr 26, 2020

Adds a detailed package docstring with the basic pieces of the library called out.
Adds documentation to run and make_engine.
Removes starting.rst in favor of including those examples in the run() documentation.

Screen shot:

init-docs

@pathunstrom pathunstrom requested a review from a team as a code owner April 26, 2020 06:01

.. automodule:: ppb

.. autofunction:: run
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you build the docs locally? I think these two should be indented.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, looked fine to me? Automodule just prints out the docstring as text, it doesn't give a heading the same way .. autoclass or .. autofunction do.

Give me a second and I'll post a screenshot.

@AstraLuma
Copy link
Member

bors r+

@bors bors bot merged commit eb27898 into ppb:master Apr 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants