Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(WIP) TargetSprite #456

Merged
merged 7 commits into from
May 7, 2020
Merged

(WIP) TargetSprite #456

merged 7 commits into from
May 7, 2020

Conversation

serin-delaunay
Copy link
Contributor

Class TargetSprite with parameters target and speed. Moves towards target at the given speed, and stops there. Will resolve #382.

pathunstrom
pathunstrom requested changes May 7, 2020
View reviewed changes
Copy link
Collaborator

@pathunstrom pathunstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one major change, is suggested so you can just accept that and we can merge this. Thanks for your first contribution!

ppb/features/default_sprites.py Outdated Show resolved Hide resolved
@serin-delaunay @pathunstrom
Update ppb/features/default_sprites.py
9a30bce 
Co-authored-by: Piper Thunstrom <pathunstrom@gmail.com>
@serin-delaunay serin-delaunay marked this pull request as ready for review May 7, 2020 02:15
@serin-delaunay serin-delaunay requested a review from a team as a code owner May 7, 2020 02:15
pathunstrom
pathunstrom approved these changes May 7, 2020
View reviewed changes
Copy link
Collaborator

@pathunstrom pathunstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, tests pass, any other polishing can be done in other PRs.

bors r+

@pathunstrom pathunstrom mentioned this pull request May 7, 2020
Closed
@bors
Copy link
Contributor

bors bot commented May 7, 2020

Build succeeded:

@bors bors bot merged commit 04888d5 into ppb:master May 7, 2020
@serin-delaunay serin-delaunay deleted the target_sprite branch May 7, 2020 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pathunstrom pathunstrom pathunstrom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Default Sprite Behaviors: TargetSprite
2 participants
@serin-delaunay @pathunstrom