Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds sprite_in_view method to replace old sprite_in_viewport. #467

Merged
merged 2 commits into from
May 13, 2020
Merged

Adds sprite_in_view method to replace old sprite_in_viewport. #467

merged 2 commits into from
May 13, 2020

Conversation

pathunstrom
Copy link
Collaborator

No description provided.

@pathunstrom pathunstrom requested a review from a team as a code owner May 12, 2020 02:06
AstraLuma
AstraLuma reviewed May 12, 2020
View reviewed changes
Copy link
Member

@AstraLuma AstraLuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaning towards approving, just want some clarifications.

ppb/camera.py Show resolved Hide resolved
ppb/camera.py Show resolved Hide resolved
tests/test_camera.py Show resolved Hide resolved
AstraLuma
AstraLuma approved these changes May 13, 2020
View reviewed changes
Copy link
Member

@AstraLuma AstraLuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@pathunstrom pathunstrom added the bors Someone has bors r+ this PR label May 13, 2020
@bors
Copy link
Contributor

bors bot commented May 13, 2020

Build succeeded:

@bors bors bot merged commit 90a1455 into ppb:master May 13, 2020
@pathunstrom pathunstrom deleted the 452-sprite-in-frame branch May 15, 2020 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AstraLuma AstraLuma AstraLuma approved these changes

Assignees
No one assigned
Labels
bors Someone has bors r+ this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pathunstrom @AstraLuma