Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation warning for python3.6 #640

Merged
merged 6 commits into from
Oct 8, 2021
Merged

Deprecation warning for python3.6 #640

merged 6 commits into from
Oct 8, 2021

Conversation

MichaelCduBois
Copy link
Contributor

This is the feature for #636

If the user is running Python 3.6 a deprecation warning is logged.

@MichaelCduBois MichaelCduBois requested a review from a team as a code owner October 1, 2021 21:09
@binny-the-binary-bear
Copy link

Thank you for contributing to PursuedPyBear! Don't forget to add yourself CONTRIBUTORS.md.

@pathunstrom
Copy link
Collaborator

Discussing this one in the discord, needed some clarification on where we want this to live and if logger.warn is the correct tool. Otherwise looks good!

Copy link
Collaborator

@pathunstrom pathunstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contributions!

bors r+

@bors
Copy link
Contributor

bors bot commented Oct 8, 2021

Merge conflict.

@pathunstrom
Copy link
Collaborator

I'll handle the merge conflict, we end up with a lot of this in October.

@pathunstrom
Copy link
Collaborator

bors retry

@bors bors bot merged commit a87329c into ppb:canon Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants