Skip to content

Commit

Permalink
extend pull image response timeout to 10min (openkruise#1288)
Browse files Browse the repository at this point in the history
Co-authored-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com>
  • Loading branch information
veophi and mingzhou.swx committed May 18, 2023
1 parent a975d12 commit 3a80fd2
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
2 changes: 1 addition & 1 deletion pkg/controller/nodeimage/nodeimage_controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ var (
const (
controllerName = "nodeimage-controller"
minRequeueDuration = 3 * time.Second
responseTimeout = time.Minute
responseTimeout = 10 * time.Minute

// Allow fake NodeImage with no Node related, just for tests
fakeLabelKey = "apps.kruise.io/fake-nodeimage"
Expand Down
14 changes: 7 additions & 7 deletions test/e2e/apps/pullimages.go
Original file line number Diff line number Diff line change
Expand Up @@ -221,13 +221,13 @@ var _ = SIGDescribe("PullImage", func() {
}, 120*time.Second, 3*time.Second).Should(gomega.Equal(int32(len(nodes))))
gomega.Expect(job.Status.CompletionTime == nil).To(gomega.Equal(true))

ginkgo.By("Wait 1 failed in 80s")
gomega.Eventually(func() int32 {
job, err = testerForImagePullJob.GetJob(job)
gomega.Expect(err).NotTo(gomega.HaveOccurred())
return job.Status.Failed
}, 80*time.Second, 3*time.Second).Should(gomega.Equal(int32(1)))
gomega.Expect(len(job.Status.FailedNodes)).To(gomega.Equal(1))
//ginkgo.By("Wait 1 failed in 80s")
//gomega.Eventually(func() int32 {
// job, err = testerForImagePullJob.GetJob(job)
// gomega.Expect(err).NotTo(gomega.HaveOccurred())
// return job.Status.Failed
//}, 80*time.Second, 3*time.Second).Should(gomega.Equal(int32(1)))
//gomega.Expect(len(job.Status.FailedNodes)).To(gomega.Equal(1))
})

framework.ConformanceIt("create two jobs to pull a same image", func() {
Expand Down

0 comments on commit 3a80fd2

Please sign in to comment.