forked from openkruise/kruise
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
pub support pod unvailable label (openkruise#1004)
- Loading branch information
Showing
10 changed files
with
481 additions
and
106 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| /* | ||
| Copyright 2022 The Kruise Authors. | ||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| package pub | ||
|
|
||
| import ( | ||
| "strings" | ||
| ) | ||
|
|
||
| const ( | ||
| // PubUnavailablePodLabelPrefix indicates if the pod has this label, both kruise workload and | ||
| // pub will determine that the pod is unavailable, even if pod.status.ready=true. | ||
| // Main users non-destructive offline and other scenarios | ||
| PubUnavailablePodLabelPrefix = "unavailable-pod.kruise.io/" | ||
| ) | ||
|
|
||
| func HasUnavailableLabel(labels map[string]string) bool { | ||
| if len(labels) == 0 { | ||
| return false | ||
| } | ||
| for key := range labels { | ||
| if strings.HasPrefix(key, PubUnavailablePodLabelPrefix) { | ||
| return true | ||
| } | ||
| } | ||
| return false | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,129 @@ | ||
| /* | ||
| Copyright 2021 The Kruise Authors. | ||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| package pubcontrol | ||
|
|
||
| import ( | ||
| "fmt" | ||
| "testing" | ||
|
|
||
| "github.com/openkruise/kruise/apis/apps/pub" | ||
| corev1 "k8s.io/api/core/v1" | ||
| ) | ||
|
|
||
| func TestIsPodUnavailableChanged(t *testing.T) { | ||
| cases := []struct { | ||
| name string | ||
| getOldPod func() *corev1.Pod | ||
| getNewPod func() *corev1.Pod | ||
| expect bool | ||
| }{ | ||
| { | ||
| name: "only annotations change", | ||
| getOldPod: func() *corev1.Pod { | ||
| demo := podDemo.DeepCopy() | ||
| return demo | ||
| }, | ||
| getNewPod: func() *corev1.Pod { | ||
| demo := podDemo.DeepCopy() | ||
| demo.Annotations["add"] = "annotations" | ||
| return demo | ||
| }, | ||
| expect: false, | ||
| }, | ||
| { | ||
| name: "add unvailable label", | ||
| getOldPod: func() *corev1.Pod { | ||
| demo := podDemo.DeepCopy() | ||
| return demo | ||
| }, | ||
| getNewPod: func() *corev1.Pod { | ||
| demo := podDemo.DeepCopy() | ||
| demo.Labels[fmt.Sprintf("%sdata", pub.PubUnavailablePodLabelPrefix)] = "true" | ||
| return demo | ||
| }, | ||
| expect: true, | ||
| }, | ||
| { | ||
| name: "image changed", | ||
| getOldPod: func() *corev1.Pod { | ||
| demo := podDemo.DeepCopy() | ||
| return demo | ||
| }, | ||
| getNewPod: func() *corev1.Pod { | ||
| demo := podDemo.DeepCopy() | ||
| demo.Spec.Containers[0].Image = "nginx:v2" | ||
| return demo | ||
| }, | ||
| expect: true, | ||
| }, | ||
| } | ||
|
|
||
| for _, cs := range cases { | ||
| t.Run(cs.name, func(t *testing.T) { | ||
| control := commonControl{} | ||
| is := control.IsPodUnavailableChanged(cs.getOldPod(), cs.getNewPod()) | ||
| if cs.expect != is { | ||
| t.Fatalf("IsPodUnavailableChanged failed") | ||
| } | ||
| }) | ||
| } | ||
| } | ||
|
|
||
| func TestIsPodReady(t *testing.T) { | ||
| cases := []struct { | ||
| name string | ||
| getPod func() *corev1.Pod | ||
| expect bool | ||
| }{ | ||
| { | ||
| name: "pod ready", | ||
| getPod: func() *corev1.Pod { | ||
| demo := podDemo.DeepCopy() | ||
| return demo | ||
| }, | ||
| expect: true, | ||
| }, | ||
| { | ||
| name: "pod not ready", | ||
| getPod: func() *corev1.Pod { | ||
| demo := podDemo.DeepCopy() | ||
| demo.Status.Conditions[0].Status = corev1.ConditionFalse | ||
| return demo | ||
| }, | ||
| expect: false, | ||
| }, | ||
| { | ||
| name: "pod contains unavailable label", | ||
| getPod: func() *corev1.Pod { | ||
| demo := podDemo.DeepCopy() | ||
| demo.Labels[fmt.Sprintf("%sdata", pub.PubUnavailablePodLabelPrefix)] = "true" | ||
| return demo | ||
| }, | ||
| expect: false, | ||
| }, | ||
| } | ||
|
|
||
| for _, cs := range cases { | ||
| t.Run(cs.name, func(t *testing.T) { | ||
| control := commonControl{} | ||
| is := control.IsPodReady(cs.getPod()) | ||
| if cs.expect != is { | ||
| t.Fatalf("IsPodReady failed") | ||
| } | ||
| }) | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.