Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dhcp network support #196

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

Karthik-K-N
Copy link
Contributor

This PR contains the changes to create and use DHCP network. This would enable us to create dhcp based base image for capi using image builder.

@Karthik-K-N
Copy link
Contributor Author

/hold for testing.

builder/powervs/step_get_network.go Outdated Show resolved Hide resolved
builder/powervs/step_create_network.go Outdated Show resolved Hide resolved
builder/powervs/step_create_network.go Show resolved Hide resolved
builder/powervs/common/run_config.go Outdated Show resolved Hide resolved
@ppc64le-cloud-bot ppc64le-cloud-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 23, 2024
@Karthik-K-N
Copy link
Contributor Author

This PR is ready for review,I have tested with image-builder and will create follow up PR to add instructions on how to do it.

Overall its works as expected, only thing is I am not able get end to end working , facing some ansible error and that I think is not related to this change.

    powervs: TASK [containerd : Copy in containerd config file etc/containerd/config.toml] ***
    powervs: An exception occurred during task execution. To see the full traceback, use -vvv. The error was: ansible.errors.AnsibleError: An unhandled exception occurred while templating '{{ containerd_wasm_shims_runtime_versions | from_json }}'. Error was a <class 'json.decoder.JSONDecodeError'>, original message: Expecting value: line 1 column 1 (char 0)
    powervs: fatal: [default]: FAILED! => {"changed": false, "msg": "AnsibleError: An unhandled exception occurred while templating '{{ containerd_wasm_shims_runtime_versions | from_json }}'. Error was a <class 'json.decoder.JSONDecodeError'>, original message: Expecting value: line 1 column 1 (char 0)"}

Copy link
Member

@mkumatag mkumatag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ppc64le-cloud-bot ppc64le-cloud-bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 25, 2024
@ppc64le-cloud-bot ppc64le-cloud-bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 25, 2024
@Karthik-K-N
Copy link
Contributor Author

Rebased to resolve merge conflicts.


require (
github.com/IBM-Cloud/power-go-client v1.6.0
github.com/IBM/go-sdk-core/v5 v5.17.0
github.com/IBM/platform-services-go-sdk v0.62.7
github.com/hashicorp/hcl/v2 v2.20.1
github.com/hashicorp/packer-plugin-sdk v0.4.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please don't bump the version to 0.5.2 because there is licence change in the recent version!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which version should I use then, I see with v0.4.0, I was hitting nil pointer error during make generate

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any latest v0.4.0 version but not 0.5.x

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait! I don't see licence file change for this package which is good, lets merge with this version update.

@ppc64le-cloud-bot ppc64le-cloud-bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 25, 2024
Copy link
Member

@mkumatag mkumatag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ppc64le-cloud-bot ppc64le-cloud-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 29, 2024
@ppc64le-cloud-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Karthik-K-N, mkumatag

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ppc64le-cloud-bot ppc64le-cloud-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 29, 2024
@ppc64le-cloud-bot ppc64le-cloud-bot merged commit 6abf24e into ppc64le-cloud:main Apr 29, 2024
18 of 19 checks passed
@Karthik-K-N Karthik-K-N deleted the update-network branch April 30, 2024 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants