-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dhcp network support #196
Add dhcp network support #196
Conversation
/hold for testing. |
310d173
to
532653f
Compare
bbee8b9
to
d911562
Compare
This PR is ready for review,I have tested with image-builder and will create follow up PR to add instructions on how to do it. Overall its works as expected, only thing is I am not able get end to end working , facing some ansible error and that I think is not related to this change.
|
d911562
to
13bf055
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
13bf055
to
3648f1a
Compare
Rebased to resolve merge conflicts. |
|
||
require ( | ||
github.com/IBM-Cloud/power-go-client v1.6.0 | ||
github.com/IBM/go-sdk-core/v5 v5.17.0 | ||
github.com/IBM/platform-services-go-sdk v0.62.7 | ||
github.com/hashicorp/hcl/v2 v2.20.1 | ||
github.com/hashicorp/packer-plugin-sdk v0.4.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please don't bump the version to 0.5.2 because there is licence change in the recent version!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which version should I use then, I see with v0.4.0, I was hitting nil pointer error during make generate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any latest v0.4.0 version but not 0.5.x
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wait! I don't see licence file change for this package which is good, lets merge with this version update.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Karthik-K-N, mkumatag The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR contains the changes to create and use DHCP network. This would enable us to create dhcp based base image for capi using image builder.