Added changes for deletion of sshKey/sshKeys #192
Conversation
ppc64le-cloud-bot
added
the
size/L
bkhadars
force-pushed
the
ssh_key
branch
2 times, most recently
from
a1fc2ea
to
0b603bb
Compare
bkhadars
force-pushed
the
ssh_key
branch
2 times, most recently
from
26b3961
to
0cd0c7c
Compare
cmd/delete/key/key.go
Outdated
| # Delete all the ssh keys which are created before 12hrs | ||
| pvsadm delete key --instance-name upstream-core --before 12h | ||
|
|
||
| #Delete all the ssh keys created since 30m | ||
| pvsadm delete key --instance-name upstream-core --since 30m | ||
|
|
||
| #Delete all ssh keys starts with rdr- | ||
| pvsadm delete key --instance-name upstream-core --regex "^rdr-.*" | ||
|
|
||
| #Delete all ssh keys without asking confirmation | ||
| pvsadm delete key --instance-name upstream-core --noprompt | ||
|
|
||
| #Delete all ssh keys and ignore if any errors during the delete operation | ||
| pvsadm delete key --instance-name upstream-core --ignore-errors |
There was a problem hiding this comment.
keys api is not tied with any instance, hence wondering if we really need the instance-name or instance-id?
There was a problem hiding this comment.
From IBM UI, we can check ssh_keys irrespective of the instances, but powervs sdk needs instance id for getting the ssh keys..
c.session.Power.PCloudTenantsSSHKeys.PcloudTenantsSshkeysGetall(params, ibmpisession.NewAuth(c.session, c.instanceID))
PcloudTenantsSshkeysGetall function needs information about instanceid, hence I have added the instance-name
There was a problem hiding this comment.
can we send an empty or some dummy value there? because API doesn't I feel.
bkhadars
force-pushed
the
ssh_key
branch
4 times, most recently
from
11d1f3c
to
1160e5b
Compare
|
@bkhadars is this ready for review? |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bkhadars, mkumatag The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ppc64le-cloud-bot
added
the
approved
Added Changes: