-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Free up loopdevice after image is built #594
Free up loopdevice after image is built #594
Conversation
@@ -29,15 +29,6 @@ import ( | |||
|
|||
const losetupCMD = "losetup" | |||
|
|||
func findFreeLoop(file string) (string, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function definition is unused.
7a6d012
to
213a270
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the quick fix @kishen-v. LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kishen-v, mkumatag The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes: #591
Before image creation:
After image creation:
After deleting image that was created.
With Fix
Before Image creation
After image creation
After deleting the image that was created.
(Avail space before image creation = Avail space after image creation)
The built image was tested on PowerVS to ensure its functioning.