Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup code and docs #625

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Cleanup code and docs #625

merged 1 commit into from
Jul 31, 2024

Conversation

kishen-v
Copy link
Contributor

No major changes apart from cleaning up docs, variable names and refactoring small segments of code.
These changes are picked-off from #612 to hold changes only related to deprecation of the bluemix-go package.

@ppc64le-cloud-bot ppc64le-cloud-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 13, 2024
@kishen-v kishen-v force-pushed the cleanup-tests branch 3 times, most recently from 108d7b3 to 87a1dfa Compare June 16, 2024 17:24
@kishen-v
Copy link
Contributor Author

cc: @Karthik-K-N, PTAL when time permits.
Thank you!

Karthik-K-N
Karthik-K-N reviewed Jul 1, 2024
View reviewed changes
Copy link
Contributor

@Karthik-K-N Karthik-K-N left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking time to go through all the files and doing cleanup and optimization.
Overall LGTM.

cmd/dhcp-sync/dhcp-sync.go Outdated Show resolved Hide resolved
@kishen-v kishen-v requested a review from Karthik-K-N July 1, 2024 05:52
Karthik-K-N
Karthik-K-N reviewed Jul 2, 2024
View reviewed changes
Copy link
Contributor

@Karthik-K-N Karthik-K-N left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ppc64le-cloud-bot ppc64le-cloud-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 2, 2024
mkumatag
mkumatag requested changes Jul 31, 2024
View reviewed changes
Copy link
Member

@mkumatag mkumatag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overal LGMT, few minor comments

cmd/create/port/port.go Outdated Show resolved Hide resolved
test/e2e/qcow2ova/qcow2ova.go Show resolved Hide resolved
test/e2e/sync/sync.go Show resolved Hide resolved
@ppc64le-cloud-bot ppc64le-cloud-bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2024
@kishen-v kishen-v requested a review from mkumatag July 31, 2024 12:38
mkumatag
mkumatag approved these changes Jul 31, 2024
View reviewed changes
Copy link
Member

@mkumatag mkumatag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ppc64le-cloud-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kishen-v, mkumatag

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ppc64le-cloud-bot ppc64le-cloud-bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 31, 2024
@ppc64le-cloud-bot ppc64le-cloud-bot merged commit f863055 into ppc64le-cloud:main Jul 31, 2024
5 checks passed
@kishen-v kishen-v deleted the cleanup-tests branch August 14, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Karthik-K-N Karthik-K-N Karthik-K-N left review comments

@mkumatag mkumatag mkumatag approved these changes

@sudeeshjohn sudeeshjohn Awaiting requested review from sudeeshjohn

Assignees

@mkumatag mkumatag

@Karthik-K-N Karthik-K-N

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kishen-v @ppc64le-cloud-bot @mkumatag @Karthik-K-N