-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor spider_all function for improved efficiency and readability #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored the spider_all function to enhance performance and code clarity. - Replaced lists with sets for queries_made and new_queries to allow O(1) average time complexity for membership checks and automatic deduplication. - Used set operations to simplify the logic for collecting and processing unique, spiderable queries. - Ensured new queries are efficiently filtered and processed without reprocessing already made queries. - Improved overall readability and maintainability of the function. This change optimizes the function by leveraging set operations, making the code more concise and efficient.
ppfeister
requested changes
Jul 21, 2024
loglevel updated to LogLevel... Co-authored-by: Paul Pfeister <code@pfeister.dev>
Co-authored-by: Paul Pfeister <code@pfeister.dev>
Applied suggestions to code. |
ppfeister
approved these changes
Jul 21, 2024
ppfeister
added a commit
that referenced
this pull request
Jul 21, 2024
Closes #3 Note: Original PR squashed for compliance with conventional commits - Replaced lists with sets for queries_made and new_queries to allow O(1) average time complexity for membership checks and automatic deduplication. - Used set operations to simplify the logic for collecting and processing unique, spiderable queries. - Ensured new queries are efficiently filtered and processed without reprocessing already made queries. - Improved overall readability and maintainability of the function. Co-authored-by: Anirudh Dilli <anirudhdilli@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change optimizes the function by leveraging set operations, making the code more concise and efficient.