Skip to content

Commit

Permalink
Exclude files without blob_url when getting PR blobs (#162)
Browse files Browse the repository at this point in the history
* Exclude files without blob_url when getting PR blobs
* Update release code
  • Loading branch information
rajbos committed Dec 12, 2023
1 parent eb148ec commit 214bf1a
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions dist/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -14701,8 +14701,8 @@ async function getPrFilesWithBlobSize(pullRequestNumber) {
})
: data;
const prFilesWithBlobSize = await Promise.all(files
// Cannot get blobs for files without sha (e.g. happens when only changing a permission bit on the file)
.filter(file => file.sha != null)
// Cannot get blobs for files without sha (e.g. happens when only changing a permission bit on the file) or without blob_url (e.g. submodules)
.filter(file => file.sha != null && file.blob_url != null)
.map(async (file) => {
const { filename, sha, patch } = file;
const { data: blob } = await octokit.rest.git.getBlob({
Expand Down
4 changes: 2 additions & 2 deletions src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -199,8 +199,8 @@ async function getPrFilesWithBlobSize(pullRequestNumber: number) {

const prFilesWithBlobSize = await Promise.all(
files
// Cannot get blobs for files without sha (e.g. happens when only changing a permission bit on the file)
.filter(file => file.sha != null)
// Cannot get blobs for files without sha (e.g. happens when only changing a permission bit on the file) or without blob_url (e.g. submodules)
.filter(file => file.sha != null && file.blob_url != null)
.map(async file => {
const {filename, sha, patch} = file;
const {data: blob} = await octokit.rest.git.getBlob({
Expand Down

0 comments on commit 214bf1a

Please sign in to comment.