Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude files without blob_url when getting PR blobs #162

Merged
merged 2 commits into from
Dec 12, 2023
Merged

Exclude files without blob_url when getting PR blobs #162

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e225977
Exclude files without blob_url when getting PR blobs
rajbos Dec 10, 2023
d8be037
Update release code
rajbos Dec 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions dist/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14701,8 +14701,8 @@ async function getPrFilesWithBlobSize(pullRequestNumber) {
})
: data;
const prFilesWithBlobSize = await Promise.all(files
// Cannot get blobs for files without sha (e.g. happens when only changing a permission bit on the file)
.filter(file => file.sha != null)
// Cannot get blobs for files without sha (e.g. happens when only changing a permission bit on the file) or without blob_url (e.g. submodules)
.filter(file => file.sha != null && file.blob_url != null)
.map(async (file) => {
const { filename, sha, patch } = file;
const { data: blob } = await octokit.rest.git.getBlob({
Expand Down
4 changes: 2 additions & 2 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,8 +199,8 @@ async function getPrFilesWithBlobSize(pullRequestNumber: number) {

const prFilesWithBlobSize = await Promise.all(
files
// Cannot get blobs for files without sha (e.g. happens when only changing a permission bit on the file)
.filter(file => file.sha != null)
// Cannot get blobs for files without sha (e.g. happens when only changing a permission bit on the file) or without blob_url (e.g. submodules)
.filter(file => file.sha != null && file.blob_url != null)
.map(async file => {
const {filename, sha, patch} = file;
const {data: blob} = await octokit.rest.git.getBlob({
Expand Down
Loading