Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add touch event cases to PassThroughInputManager #3270

Merged
merged 7 commits into from
Jun 26, 2020

Conversation

frenzibyte
Copy link
Member

@frenzibyte frenzibyte commented Feb 16, 2020

Split from #2925

Adds touch event cases to the PassThroughInputManager for propagating touch input to the hierarchy.

@pull-request-size pull-request-size bot added size/L and removed size/S labels Jun 25, 2020
@frenzibyte frenzibyte requested a review from peppy June 25, 2020 09:16
@frenzibyte
Copy link
Member Author

I believe the mouse button synchronization is done as-is (release stale but don't press new) for the input to not potentially be mistaken as a click, not the case for touches so decided it to follow the rest.

@bdach
Copy link
Collaborator

bdach commented Jun 25, 2020

While that makes sense to me (clicks are transient, discrete events, while a touch is persistent), it may be something worth documenting in some way.

@frenzibyte
Copy link
Member Author

Yeah definitely, will push another branch for that.

@peppy peppy merged commit 5e752b2 into ppy:master Jun 26, 2020
@frenzibyte frenzibyte deleted the pass-through-touch-input branch June 26, 2020 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants