Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix backspace not working properly with hardware keyboards #5275

Merged
merged 2 commits into from
Jun 29, 2022

Conversation

Susko3
Copy link
Member

@Susko3 Susko3 commented Jun 27, 2022

Depends on:

Android basically doesn't send the key up event for backspace. Really strange behaviour, I guess they expect text boxes not to care about key up events and instead rely on native key repeat.

Key up events works just find when text input is disabled (a.k.a. when OnCreateInputConnection() returns null).

@Susko3 Susko3 changed the title Fix backspace not working properly with hardware keyboard Fix backspace not working properly with hardware keyboardss Jun 27, 2022
@Susko3 Susko3 changed the title Fix backspace not working properly with hardware keyboardss Fix backspace not working properly with hardware keyboards Jun 27, 2022
@bdach
Copy link
Collaborator

bdach commented Jun 28, 2022

I'll approve because I tested and it works, but I won't merge without a second approval because the fix is pretty hideous alll things considered.

All the above notwithstanding, the android input handling paradigm is likely terminally incompatible with physical keyboards, so I'm not exactly expecting there to be any saner way to do this than what's here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Backspace not working on external keyboard android
3 participants