Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Waveform generation failing when using "no sound" device #5310

Merged
merged 2 commits into from
Jul 18, 2022

Conversation

peppy
Copy link
Member

@peppy peppy commented Jul 18, 2022

Closes ppy/osu#18479 (probably... unless there are other cases. fine to close until it comes up again).

@frenzibyte
Copy link
Member

frenzibyte commented Jul 18, 2022

I looked at the issue thread and noticed there was logs attached, and it had the following in the log:

2022-05-29 13:27:39 [verbose]: 🔈 BASS initialised
2022-05-29 13:27:39 [verbose]: BASS version:           2.4.16.7
2022-05-29 13:27:39 [verbose]: BASS FX version:        2.4.12.6
2022-05-29 13:27:39 [verbose]: BASS MIX version:       2.4.11.1
2022-05-29 13:27:39 [verbose]: Device:                 No sound
2022-05-29 13:27:39 [verbose]: Driver:
2022-05-29 13:27:39 [verbose]: Update period:          5 ms
2022-05-29 13:27:39 [verbose]: Device buffer length:   10 ms
2022-05-29 13:27:39 [verbose]: Playback buffer length: 100 ms
2022-05-29 13:27:39 [verbose]: 🔈 BASS initialised
2022-05-29 13:27:39 [verbose]: BASS version:           2.4.16.7
2022-05-29 13:27:39 [verbose]: BASS FX version:        2.4.12.6
2022-05-29 13:27:39 [verbose]: BASS MIX version:       2.4.11.1
2022-05-29 13:27:39 [verbose]: Device:                 Default
2022-05-29 13:27:39 [verbose]: Driver:
2022-05-29 13:27:39 [verbose]: Update period:          5 ms
2022-05-29 13:27:39 [verbose]: Device buffer length:   10 ms
2022-05-29 13:27:39 [verbose]: Playback buffer length: 100 ms

I tested locally on Windows by disabling all sound devices and this is what I'm seeing instead:

2022-07-18 08:07:47 [verbose]: 🔈 BASS initialised
2022-07-18 08:07:47 [verbose]: BASS version:           2.4.16.7
2022-07-18 08:07:47 [verbose]: BASS FX version:        2.4.12.6
2022-07-18 08:07:47 [verbose]: BASS MIX version:       2.4.11.1
2022-07-18 08:07:47 [verbose]: Device:                 No sound
2022-07-18 08:07:47 [verbose]: Driver:
2022-07-18 08:07:47 [verbose]: Update period:          5 ms
2022-07-18 08:07:47 [verbose]: Device buffer length:   10 ms
2022-07-18 08:07:47 [verbose]: Playback buffer length: 100 ms
2022-07-18 08:07:47 [verbose]: 🔈 BASS initialised
2022-07-18 08:07:47 [verbose]: BASS version:           2.4.16.7
2022-07-18 08:07:47 [verbose]: BASS FX version:        2.4.12.6
2022-07-18 08:07:47 [verbose]: BASS MIX version:       2.4.11.1
2022-07-18 08:07:47 [verbose]: Device:                 No sound
2022-07-18 08:07:47 [verbose]: Driver:
2022-07-18 08:07:47 [verbose]: Update period:          5 ms
2022-07-18 08:07:47 [verbose]: Device buffer length:   10 ms
2022-07-18 08:07:47 [verbose]: Playback buffer length: 100 ms

So I'm not 100% sure if it's really about "no sound", but probably fine to close this until it comes up again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Editor track's waveform not generating occasionally
2 participants