Add callbacks to text selection events of TextBox #5366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Susko3
reviewed
Aug 20, 2022
Susko3
suggested changes
Aug 20, 2022
Comment on lines
1575
to
1577
| if (userEvent) OnImeComposition(newComposition, removeCount, addCount, oldStart != selectionStart || oldEnd != selectionEnd); | ||
|
|
||
| onTextSelectionChanged(newSelectionLength > 0 ? TextSelectionType.Character : TextSelectionType.Deselect); |
There was a problem hiding this comment.
Not sure this is valid, as IME input is quite different from regular text input. I'd rather add newSelectionLength (or textSelected) to OnImeComposition.
With the osu!-side PR, this currently produces sounds for both OnImeComposition and OnTextSelectionChanged.
There was a problem hiding this comment.
Hrm, I'll re-check the behaviour with IME.
Co-authored-by: Susko3 <Susko3@protonmail.com>
peppy
reviewed
Aug 25, 2022
peppy
approved these changes
Aug 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will be used for adding audio feedback to text selection in lazer