Disable manual mipmap generation (and decrease atlas size again) #5765
Conversation
With the custom mipmap generation logic disabled, the maximum texture atlas size needs to be decreased to 1024 again to mitigate `glMipmap()`'s bad performance characteristics.
|
Before/after screenshots from devices I own:
Change is most apparent on the toolbar icons. |
|
Can confirm on my Pixel 6a that ppy/osu#23240 and ppy/osu#23318 are fixed. |
|
That means the stuttering will come back? With high atlas size seems reduced the stuttering on my Redmi Note 9 phone. For me, I don't mind having text weirdness in expense for performance or less stuttering. |
|
That's correct. Please read the OP. |
|
I'm sorry but I don't know what is "OP" you're referring. But I'm not gonna install the next updates for now until it come back or something replaced it that can reduce the stuttering while playing. What important to me is performance as it affects the whole game for me. If I just have money, I would buy a high-end android phone. |
|
@Shirou27 OP = opening post This revert is a temporary measure. We're hoping to get these changes back in again as they do end up improving performance on a wide range of devices, but not at the expense of the game looking as bad as it does on some devices in the previous state. You're of course well within your rights to skip installing updates until then. Thanks for your understanding. |
As per today's discussion in discord, this disables the meaningful changes made in #5508 to restore operation on configurations that have been negatively affected by the change (primarily appears to be mobile).
This is not a direct revert, and the goal was to keep the mipmap generation code in the tree, just in a disabled state, to permit revisiting the issue at a later date if necessary.
#5757 is a possible avenue for improvement in this stage, but it is currently not ready and @frenzibyte has no throughput to address the issues therein.