Make RearrangeableListContainer<> only replace differences
#6425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
bdach
approved these changes
Nov 18, 2024
Comment on lines
+108
to
+112
| IEnumerable<TModel> tOldItems = e.OldItems?.Cast<TModel>() ?? []; | ||
| IEnumerable<TModel> tNewItems = e.NewItems?.Cast<TModel>() ?? []; | ||
|
|
||
| removeItems(tOldItems.Except(tNewItems)); | ||
| addItems(tNewItems.Except(tOldItems)); |
There was a problem hiding this comment.
The only qualm I have about this is how this implicitly relies on equality semantics, i.e. on TModel having a sane equality implementation. But I guess maybe fine to try...?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
ReplaceRange()it will no longer re-add items that were previously and still are in the list.