-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve chat channel unread marker handling #9006
Improve chat channel unread marker handling #9006
Conversation
what's the exact repro steps for this? |
cases where it shouldn't be considered read:
|
this.markAsReadTimeout = null; | ||
} | ||
|
||
this.markAsReadLastSent = lastReadId; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't this check if LastSent >= lastReadId
as well? updateWithJson
may update the value outside this function (and the same check when setting the value in there?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure the delay is even needed, thinking about it again...
we were sending a captured value anyway, so there was really no reason to delay it... ...not even sure the throttle is needed 🤔
Decouples the previous
markAsRead
from setting the unread marker position and uses the marker position when marking as read instead of assuming the last message.There was an issue where when scrolling to the bottom of a channel and then scrolling back up and down again, if the scroll was not quite at the bottom of the channel when switching, it would not mark the channel as read.
(As an aside, this also means the client can just set the marker to some midway point instead of the end)
should fix #9003