Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VSCode line ending setting for github.dev #11868

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Conversation

cl8n
Copy link
Member

@cl8n cl8n commented Jul 30, 2024

the web version of vscode doesn't take hints for this setting from gitattributes or editorconfig, so it has to be set explicitly like this (or at least I didn't find a better way). this has the unfortunate side effect of tracking the workspace settings file, so any further workspace-level changes any vscode user makes will have to be "assume unchanged" in the git index -- for some reason there is only one possible workspace settings file name (microsoft/vscode#40233), so I found no better way to avoid this either.

resolves #11861

@cl8n cl8n added the area:meta non-article files label Jul 30, 2024
@peppy
Copy link
Member

peppy commented Jul 31, 2024

this has the unfortunate side effect of tracking the workspace settings file

Probably better than not having it at all.

@peppy peppy merged commit 7c3a00a into ppy:master Jul 31, 2024
5 checks passed
@cl8n cl8n deleted the github-dev-eol branch July 31, 2024 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:meta non-article files size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configure github.dev environment to use LF for new files
2 participants