Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing sound effects #14082

Open
10 tasks done
peppy opened this issue Jul 31, 2021 · 6 comments
Open
10 tasks done

Missing sound effects #14082

peppy opened this issue Jul 31, 2021 · 6 comments
Assignees
Labels
audio priority:2 Moderately important. Relied on by some users or impeding the usability of the game

Comments

@peppy
Copy link
Member

peppy commented Jul 31, 2021

In an interest of hopefully helping @nekodex with remaining coverage, here's some sound effect related holes that came up during a play session:

@peppy peppy added audio priority:2 Moderately important. Relied on by some users or impeding the usability of the game labels Jul 31, 2021
@Gabixel
Copy link
Contributor

Gabixel commented Aug 9, 2021

(I guess it makes sense to post this here instead of creating another issue.)
I would suggest adding a "switch" sound when switching between chats with the keyboard shortcut (CTRL + TAB). Currently, only the "click" sound plays when switching (ignoring whether you used the mouse or the keyboard):

Chat.Tabs.mp4

I'm 50% sure that it could be different for keyboard users (but my other 50% thinks that it's not that wrong).

@Theighlin

This comment has been minimized.

@peppy
Copy link
Member Author

peppy commented Aug 10, 2021

Other sounds that are missing in comparison to stable are in a multi lobby the ready/unready state change, the change of map and when you're given host. Plus the spectate button could use one too and one when the map ends for someone waiting in an already started lobby would be useful.

To confirm, you mean the "host" changing their ready state? Other users already has a sound effect (although it was made much softer by @nekodex sample changes, I believe..)

@Theighlin
Copy link

Theighlin commented Aug 10, 2021

To confirm, you mean the "host" changing their ready state? Other users already has a sound effect (although it was made much softer by @nekodex sample changes, I believe..)

I just checked, the player changing ready state button (user as well as host) has a sound, but what i originally meant is that it should have a more distinct one like in stable and not be the same as all other buttons (could have been the skin that made it different but it should be there also on default one if not).
If it has its own sound as you say, there's either something not working or it is incredibly low because i couldn't hear it

The sound is there, it's okay for other users, but should be different when one change it's own state.

I'll recap my previous comment and add a couple of things here

  • When changing state to ready and not ready (2 different sounds)
  • When a beatmap is changed
  • When you're given host
  • When a user is kicked
  • When players join and leave the room
  • When gameplay ends so to alert users waiting in lobby.
  • Changing room match type (could have different sounds like changing ruleset imo)
osu.2021-08-10.20-47-47.mp4

@Gabixel
Copy link
Contributor

Gabixel commented Sep 2, 2022

As per a recent post (#20099, which I will transfer here), textboxes don't play any sound when cleared with the Esc key:

textbox.mp4

The sound that is played when deleting a character could be appropriate for this.

@peppy
Copy link
Member Author

peppy commented Dec 12, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
audio priority:2 Moderately important. Relied on by some users or impeding the usability of the game
Projects
Archived in project
Development

No branches or pull requests

4 participants