Update SFX for mod select overlay show/hide

[nekodex]

• depends on Add samples for mod select overlay show/hide osu-resources#202

[peppy]

Two things to note with this (non-critical but maybe worth considering?):

• Because the initial display of the mod screen favours the columns being further to the right, the balance of the individual columns feels lob-sided towards the right. It's probably best to fake it and offset to allow them to feel balanced (ie. add a left bias equal to the visual offset of the first column).
• The sound of the clicking of the "mods" button at song select is a bit overpowering. I don't think it really fits that well, and would probably work better as one of the softer button click sounds (especially since all three of the buttons there have their own sounds that play after click now).

[nekodex]

• Because the initial display of the mod screen favours the columns being further to the right, the balance of the individual columns feels lob-sided towards the right. It's probably best to fake it and offset to allow them to feel balanced (ie. add a left bias equal to the visual offset of the first column).

Yeah, that makes sense. I guess the only thing I'd check is whether it feels off when the screen aspect ratio is wide enough such that the columns appear completely on the left.

• The sound of the clicking of the "mods" button at song select is a bit overpowering. I don't think it really fits that well, and would probably work better as one of the softer button click sounds (especially since all three of the buttons there have their own sounds that play after click now).

I still consider those mod button sounds as placeholders, so feel free to swap it for something else for the time being.

[peppy]

This conditional is a tad weird to read. To confirm, the goal is to play the sound even for off-screen columns up to a max of 5 to make the effect sound correct?

[nekodex]

yes

[peppy]

Hmm, the only discrepancy is that it will play 6 times with the code you have.

[peppy]

Actually after changing the button sound, the balance seems fine. It feels less bad without the button sound hiding the first few columns' sounds.