Mod setting serialisation is dependent on current culture

[ppy-sentryintegration]

Note the dotless "i" in ınitial_rate. This is happening because the users are using the Turkish language.

Resolution is not obvious as the offending .ToLower() call is in humanizer, in .Underscore(), which we use for serialising settings:

https://github.com/ppy/osu/blob/master/osu.Game/Online/API/APIMod.cs#L45

---

Sentry Issue: OSU-1Y2

System.Net.WebException: UnprocessableEntity
  ?, in Task WebRequest.Complete(Exception e)
  ?, in async Task WebRequest.beginResponse(CancellationToken cancellationToken)
  ?, in async Task WebRequest.internalPerform(CancellationToken cancellationToken)

osu.Game.Online.API.APIException: unknown setting for WD (ınitial_rate)

Failed to submit score

[bdach]

Submitted issue about this upstream to see if we can maybe get this fixed there somehow (Humanizr/Humanizer#1212).

[bdach]

Upstream is unresponsive for now. There were suggestions of adding our own copies of the affected methods and fixing ourselves - any objections to that? Thoughts on where the copies should live?

I'm also thinking of banning string.To{Lower,Upper}() as there are other usages that look suspect. LocalisableString.To{Lower,Upper}() would stay unbanned, because there the culture-variant behaviour of lower/upper is actually desired.

[frenzibyte]

Can agree with that, sounds like it would work quite well. For the copies, I would imagine them living in a StringExtensions class, and ban the Humanizer ones as to not conflict with them.