Disallow usage of string.To{Upper,Lower}()
without explicit culture
#18834
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as ppy/osu-framework#5261. Vaguely related to #18729.
I have changes planned to address the issue linked by replacing humanizer methods with game-side fixed copies but I'm PRing this separately to reduce size since this touches a good few files.
Guidelines taken when replacing:
LocalisableString
(two cases of this here).