Random loud audio crackle upon clicking "View Results" in playlists

[TomG16]

Type

Game behaviour

Bug description

A varying in loudness click/crackle can be heard upon clicking the "View Results" button of a song in playlists.

-It varies between to a loud click to sometimes not even noticeable. Also happens with music/effects ON

Screenshots or videos

cracklebuglazer.mp4

Version

2022.821.0

Logs

runtime.log
network.log
updater.log
performance.log
database.log
legacy-ipc.log

[smoogipoo]

Sounds like the sample is potentially played with 100% volume for one frame or something.

[peppy]

Looks to be related to DrawableAudioMixer as used here:

osu/osu.Game/Screens/Ranking/ScorePanel.cs

Line 102 in 475679c

private DrawableAudioMixer mixer;

Changing this to an AudioContainer fixes the issue.

I'll take a brief journey to see if I can figure the underlying cause, but I don't actually think a mixer is appropriate or required here.

[peppy]

This happens without any sample playback. Just having the CreateMixer calls is enough.

JetBrains.Rider.2022-08-30.at.06.17.12.mp4

Note the volume spikes here. This is with game volume set to 0% and sample playback disabled (as shown top-left).