Fix audio glitching when showing results screen with many scores #20025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Change seems tolerable but I can't seem to be able to repro the original issue on my linux install in the first place, so I'm leaving for someone else to check. |
|
To repro the issue, set master volume to 0% then enter and exit results of a playlist item with many users with scores. Can confirm it happens on macOS (and the original report was on windows). It may be platform specific. It does look like a bass-side issue/quirk (buffers being purged when a new mixer is added) and may not repro as readily on linux. |
smoogipoo
approved these changes
Aug 31, 2022
This was referenced Sep 1, 2022
This was referenced Sep 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20017 in the simplest way possible (removing usage of many
DrawableAudioMixers).Will need to investigate the actual issue further over at framework, but this should do for now (and greatly reduce the overhead of displaying the results screen from a bass-perspective).