Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add beatmap icon to windows beatmap files #29812

Merged
merged 3 commits into from
Sep 14, 2024

Conversation

smallketchup82
Copy link
Contributor

@smallketchup82 smallketchup82 commented Sep 9, 2024

This PR adds the beatmap icon from stable to beatmap files for osu!lazer on windows

Testing Checklist

  • Test if displays correctly
    image

Note: This would require the association updating logic to be in for another release

@bdach
Copy link
Collaborator

bdach commented Sep 11, 2024

This functionality was missing from #27001.

It was not "missing," I just didn't particularly think those assets fit the current design of the logo and everything else. See also: #25414.

Paging @arflyte for design input. To explain, I'd be looking for a replacement of the icon shown below that is more in line with the rest of the game's current visual identity:

osu_Beatmap_Pack_Icon 1

@arflyte
Copy link

arflyte commented Sep 11, 2024

Damn, this is a very old file with v1 texture. I'll come up with a new one.

@peppy
Copy link
Member

peppy commented Sep 11, 2024

Keep in mind people are used to the existing icon's shape, so Is hope for something that carries a similar feeling.

@arflyte
Copy link

arflyte commented Sep 11, 2024

Revised Beatmap Icon. Already tested for legibility at small sizes, should work well.

Beatmap Icon

Figma file: https://www.figma.com/design/JgSGruE8ZkXWgfyUCzy6RH/Beatmap-Icon?node-id=1-23&t=Ol0YxIDookNccpry-1

@peppy
Copy link
Member

peppy commented Sep 11, 2024

I quite like it, but the top right corner feels... a bit off. I think the fold is too large or something, it makes the whole thing look bulgy in a weird way.

@peppy
Copy link
Member

peppy commented Sep 11, 2024

Also I think it's missing a drop shadow. It will look bad on white backgrounds:

2024-09-12 00 44 28@2x

@bdach can you confirm where you got the above export from? because in window explorer the original does have a shadow (and I don't think windows adds that?):

2024-09-12 01 03 02@2x

@bdach
Copy link
Collaborator

bdach commented Sep 11, 2024

The export is from #25414.

@peppy
Copy link
Member

peppy commented Sep 11, 2024

RIght (tanza missed the shadow). Either way, it needs a drop shadow to be functional (@arflyte please stick a todo note to your monitor to check designs against colour extremes as this is a recurring theme).

I'd also highly recommend converting to an .ico and testing in windows explorer at all sizes, and providing screenshots of how it looks against light and dark, so we can be convinced you've put in the effort and due diligence.

If you can provide the .ico file with correct specs that's a bonus.

@arflyte
Copy link

arflyte commented Sep 11, 2024

I was under the assumption that Windows would add the shadow itself.

Added shadows for now. Didn't change the design yet (if anyone is still not happy with the design). Added additional design tests itself into the Figma file.

Figma_240912-024439

Wouldn't call myself an .ico expert or how Windows handle it, but I couldn't figure out if Windows added additional box shadow or the multiple online converters that I tried. So I'll let you experts figure that out. I've provided the converted .ico nonetheless below.

explorer_240912-024333
explorer_240912-025559
explorer_240912-025613
explorer_240912-024252
explorer_240912-024321

Beatmap.zip <- .ico file
Beatmap Icon <- original png

In the meantime, I'll figure out on how to improve the design.

Comment on lines 45 to 46
new FileAssociation(@".osr", WindowsAssociationManagerStrings.OsuReplay, Icons.Lazer),
new FileAssociation(@".osk", WindowsAssociationManagerStrings.OsuSkin, Icons.Lazer),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're here redesigning icons, how about these?

FWIW stable also just uses the music icon for these, so we don't have a reference icon to go by if we want distinct icons.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we plan on redesigning the icons for each file type, I think we can use the same design as beatmaps, but change the symbols. For example, replays can use a clock with an arrow rotating left. And for skins, we can use a paintbrush or a palette.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peppy peppy merged commit 18ab4ee into ppy:master Sep 14, 2024
13 checks passed
@smallketchup82 smallketchup82 deleted the add-beatmap-icon branch October 8, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants