-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add beatmap icon to windows beatmap files #29812
Conversation
It was not "missing," I just didn't particularly think those assets fit the current design of the logo and everything else. See also: #25414. Paging @arflyte for design input. To explain, I'd be looking for a replacement of the icon shown below that is more in line with the rest of the game's current visual identity: |
Damn, this is a very old file with v1 texture. I'll come up with a new one. |
Keep in mind people are used to the existing icon's shape, so Is hope for something that carries a similar feeling. |
Revised Beatmap Icon. Already tested for legibility at small sizes, should work well. Figma file: https://www.figma.com/design/JgSGruE8ZkXWgfyUCzy6RH/Beatmap-Icon?node-id=1-23&t=Ol0YxIDookNccpry-1 |
I quite like it, but the top right corner feels... a bit off. I think the fold is too large or something, it makes the whole thing look bulgy in a weird way. |
Also I think it's missing a drop shadow. It will look bad on white backgrounds: @bdach can you confirm where you got the above export from? because in window explorer the original does have a shadow (and I don't think windows adds that?): |
The export is from #25414. |
RIght (tanza missed the shadow). Either way, it needs a drop shadow to be functional (@arflyte please stick a todo note to your monitor to check designs against colour extremes as this is a recurring theme). I'd also highly recommend converting to an .ico and testing in windows explorer at all sizes, and providing screenshots of how it looks against light and dark, so we can be convinced you've put in the effort and due diligence. If you can provide the .ico file with correct specs that's a bonus. |
I was under the assumption that Windows would add the shadow itself. Added shadows for now. Didn't change the design yet (if anyone is still not happy with the design). Added additional design tests itself into the Figma file. Wouldn't call myself an .ico expert or how Windows handle it, but I couldn't figure out if Windows added additional box shadow or the multiple online converters that I tried. So I'll let you experts figure that out. I've provided the converted .ico nonetheless below. Beatmap.zip <- .ico file In the meantime, I'll figure out on how to improve the design. |
new FileAssociation(@".osr", WindowsAssociationManagerStrings.OsuReplay, Icons.Lazer), | ||
new FileAssociation(@".osk", WindowsAssociationManagerStrings.OsuSkin, Icons.Lazer), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we're here redesigning icons, how about these?
FWIW stable also just uses the music icon for these, so we don't have a reference icon to go by if we want distinct icons.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we plan on redesigning the icons for each file type, I think we can use the same design as beatmaps, but change the symbols. For example, replays can use a clock with an arrow rotating left. And for skins, we can use a paintbrush or a palette.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR adds the beatmap icon from stable to beatmap files for osu!lazer on windows
Testing Checklist
Note: This would require the association updating logic to be in for another release