Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the converted osu and mime .svg files #25414

Closed
wants to merge 5 commits into from
Closed

Conversation

ghost
Copy link

@ghost ghost commented Nov 12, 2023

as recommended by peppy, as i said in the original pr, they are rough and was converted from the existing png ones, if better quality .svg icons or the original raw files is found i update this pr

@Tanza3D
Copy link

Tanza3D commented Nov 12, 2023

those are horrific
for the former (osz file) i think it'd be a nice idea to try get a new one, i'd be happy to give that a shot if peppy's okay with it
for the latter (osu! logo) im certain that's in vector somewhere, but if not i think recreating it should be a better route than this bad trace, would also be happy to do this

@bdach
Copy link
Collaborator

bdach commented Nov 13, 2023

For visibility, I asked for better versions of these internally.

@agatemosu
Copy link

agatemosu commented Nov 13, 2023

I know that on osu-web there is the background and the letters (like the main menu) of the logo in two separate SVGs
https://github.com/ppy/osu-web/blob/master/public/images/layout/osu-logo-white.svg
https://github.com/ppy/osu-web/blob/master/public/images/layout/osu-logo-triangles.svg

@Tanza3D
Copy link

Tanza3D commented Nov 13, 2023

I know that on osu-web there is the background and the letters (like the main menu) of the logo in two separate SVGs https://github.com/ppy/osu-web/blob/master/public/images/layout/osu-logo-white.svg https://github.com/ppy/osu-web/blob/master/public/images/layout/osu-logo-triangles.svg

different logo, that's not lazer's

@Tanza3D
Copy link

Tanza3D commented Nov 13, 2023

best recreation of mime.svg i can do

mime

@ghost
Copy link
Author

ghost commented Nov 13, 2023

best recreation of mime.svg i can do

mime

want me to update with this version on the commit?

@Tanza3D
Copy link

Tanza3D commented Nov 13, 2023

best recreation of mime.svg i can do
mime

want me to update with this version on the commit?

up to you

@bdach
Copy link
Collaborator

bdach commented Nov 14, 2023

The original assets for the file type icons are apparently these illustrator files: icons.zip

I don't have illustrator so I can't very easily make use of these though.

@Tanza3D
Copy link

Tanza3D commented Nov 14, 2023

original assets were quite complex and messy when converted to svg and made use of transparent black layers instead of just solid darker pinks (which i felt could be bad for performance) so i've taken some time with the original to clean it up a bit and remove unnecessary paths and such (check the svg code to see what i mean)

original

osu_Beatmap_Pack_Icon 1

cleaned

osu_Beatmap_Pack_Icon-cleaned

only thing is that the shadow is completely missing from these as illustrator can only export those as images embedded inside the svgs, can try add it on myself if wanted
(thanks to nhiil for doing the base ai to svg conversion for me, stopped paying for adobe years ago lol)

@ghost
Copy link
Author

ghost commented Nov 15, 2023

pr updated :)

@bdach
Copy link
Collaborator

bdach commented Feb 22, 2024

I'm going to go ahead and close this since I'm not certain we'll be using either of these assets anymore at this point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants