Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't floor effectiveMissCount #16331

Merged
merged 2 commits into from
Jan 19, 2022
Merged

Don't floor effectiveMissCount #16331

merged 2 commits into from
Jan 19, 2022

Conversation

stanriders
Copy link
Member

Related to #16280

@stanriders stanriders requested a review from a team January 5, 2022 11:37
@pull-request-size pull-request-size bot added size/S and removed size/XS labels Jan 5, 2022
@bdach
Copy link
Collaborator

bdach commented Jan 5, 2022

Can get behind this in general, but maybe there should be some xmldoc or other inline comment explaining how that miss count can be fractional? Probably would put it as xmldoc on the PerformanceAttributes property.

This was referenced Jan 6, 2022
Merged
Merged
@smoogipoo
Copy link
Contributor

Spreadsheet of changes: https://docs.google.com/spreadsheets/d/1JuznoYWJUQJFWigb10R-YCSgfal5xVDvR_rSlKe2dhE/edit#gid=1165396648

@smoogipoo smoogipoo merged commit 58bae9b into ppy:master Jan 19, 2022
@bdach bdach mentioned this pull request Jan 28, 2022
Merged
@apollo-dw apollo-dw mentioned this pull request Jan 30, 2022
Closed
@stanriders stanriders deleted the continuous-effective-misscount branch August 2, 2024 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smoogipoo smoogipoo smoogipoo approved these changes

Assignees
No one assigned
Labels
area:difficulty ruleset/osu! size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stanriders @bdach @smoogipoo